2011-03-10 20:55:31 +01:00
|
|
|
|
* Global
|
|
|
|
|
|
2011-08-26 16:08:39 +02:00
|
|
|
|
- Known bugs
|
2011-12-30 14:42:37 +01:00
|
|
|
|
° Valgrind / libconfuse bugs (Listener & Aggregator):
|
2011-08-26 16:08:39 +02:00
|
|
|
|
. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=639074
|
|
|
|
|
. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=639115
|
2012-06-21 18:43:12 +02:00
|
|
|
|
- Handle the aggregation format version
|
|
|
|
|
In the aggregation files, a version number describing the file format
|
|
|
|
|
should be added (as the 2nd field, right after the client's MAC
|
|
|
|
|
address). That would allow the positioning server to handle several
|
|
|
|
|
formats instead of just the last version.
|
2012-02-06 11:35:53 +01:00
|
|
|
|
- Check the size of the received packets to avoid buffer overflows.
|
|
|
|
|
- Use select(2) or poll(2)
|
|
|
|
|
Using polling for sockets would avoid setting up some threads,
|
|
|
|
|
especially the autocalibration threads in the Listener,
|
|
|
|
|
i.e. autocalibrate() and autocalibrate_hello(), and listen_for_aps()
|
|
|
|
|
in the Aggregator.
|
|
|
|
|
See also select_tut(2).
|
|
|
|
|
- Option -V should tell if DEBUG is enabled or not.
|
2011-08-26 16:08:39 +02:00
|
|
|
|
- Eliminate remaining exit() calls to avoid memory leaks on exit.
|
2011-12-30 14:42:37 +01:00
|
|
|
|
- Use atexit() / on_exit() instead of goto to clean at exit?
|
2011-07-29 22:26:38 +02:00
|
|
|
|
- Add option dump-configuration (displays the config & exits).
|
2011-05-03 13:53:33 +02:00
|
|
|
|
- Makefiles:
|
2011-12-30 14:42:37 +01:00
|
|
|
|
° Use intall instead of cp?
|
2011-07-29 22:26:38 +02:00
|
|
|
|
° Merge Makefile and Makefile_atheros*. Use template makefiles,
|
|
|
|
|
autohell, cmake…?
|
2012-02-07 12:41:29 +01:00
|
|
|
|
- Support string-based positioning requests
|
|
|
|
|
Along with the binary requests, implement a string-based request
|
|
|
|
|
format. Each packet will contain a CSV string describing the
|
|
|
|
|
request's information. This will make easier to develop clients in
|
|
|
|
|
other languages than C and over other protocols than UDP.
|
2011-03-10 20:55:31 +01:00
|
|
|
|
- Mark arguments as const in function headers if needed
|
2012-02-07 12:41:29 +01:00
|
|
|
|
Mostly done in the Positioner C++ code (which should be checked
|
|
|
|
|
though), but not constantly in C modules.
|
2011-06-08 10:56:14 +02:00
|
|
|
|
[Done in libowlps & libowlps-client.]
|
2011-04-07 10:18:06 +02:00
|
|
|
|
- Allow to use hostnames instead of IP addresses in all modules
|
|
|
|
|
getaddrinfo(3) (or gethostbyname(3)) should be used when opening
|
|
|
|
|
sockets in libowlps, then string buffer size have to be adapted in
|
|
|
|
|
all modules to be able to contain a long hostname.
|
2011-03-25 10:16:41 +01:00
|
|
|
|
- Use struct ether_addr to store MAC addresses?
|
|
|
|
|
We could use the struct ether_addr to store binary MAC addresses,
|
|
|
|
|
and convert them to strings with ether_ntoa() instead of
|
|
|
|
|
owl_mac_bytes_to_string(). See ether_aton(3).
|
2011-03-10 20:55:31 +01:00
|
|
|
|
|
|
|
|
|
|
2011-03-25 17:20:18 +01:00
|
|
|
|
* libowlps
|
|
|
|
|
|
2011-12-30 14:42:37 +01:00
|
|
|
|
- Use stdbool.h instead of #define owl_bool.
|
2011-04-07 10:18:06 +02:00
|
|
|
|
- Currently unused functions:
|
|
|
|
|
° owl_timestamp_is_null()
|
2011-03-25 17:20:18 +01:00
|
|
|
|
|
|
|
|
|
|
2011-03-10 20:55:31 +01:00
|
|
|
|
* Aggregator
|
|
|
|
|
|
2011-07-29 22:26:38 +02:00
|
|
|
|
- -o should be optional.
|
|
|
|
|
- Add an option to (not) flush the output file.
|
2012-06-08 19:16:55 +02:00
|
|
|
|
- Outputs should include all the timestamps
|
|
|
|
|
The CSV output file and the socket should include the capture
|
|
|
|
|
timestamp and the reception timestamp on the aggregator. This would
|
|
|
|
|
help the Positioner's --replay option (to be adapted to use the
|
|
|
|
|
aggregation time instead of the request time).
|
2012-02-07 12:41:29 +01:00
|
|
|
|
- Refactoring:
|
2011-07-29 22:26:38 +02:00
|
|
|
|
° monitor_requests()
|
|
|
|
|
° got_request()
|
2011-03-25 17:20:18 +01:00
|
|
|
|
- Use the type of a request to identify it?
|
|
|
|
|
(along with the mobile MAC address and the request time)
|
2011-03-25 10:39:02 +01:00
|
|
|
|
- got_request(): option for the maximal difference time
|
2011-06-08 10:56:14 +02:00
|
|
|
|
For implicit packets, we consider that packets from the same MAC
|
|
|
|
|
and received within an interval of 10ms are part of the same
|
2011-03-25 10:39:02 +01:00
|
|
|
|
request. We should define an option to allow user to choose the
|
|
|
|
|
time he wants.
|
2011-03-10 20:55:31 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* Listener
|
|
|
|
|
|
2012-02-06 11:35:53 +01:00
|
|
|
|
- Known bugs:
|
|
|
|
|
° On OpenWrt Backfire (10.03), when the program is statically linked,
|
|
|
|
|
using both -D and -A at the same time makes the program to block on
|
2012-02-07 12:41:29 +01:00
|
|
|
|
the first thread. This is a known issue of uClibc:
|
2012-02-06 11:35:53 +01:00
|
|
|
|
https://dev.openwrt.org/ticket/4809
|
2012-05-31 20:42:11 +02:00
|
|
|
|
- Better handling of retried packets
|
|
|
|
|
Currently we ignore any packet with the Retry bit. This can lead to
|
|
|
|
|
completely ignore the given packet (or even request) if the original
|
|
|
|
|
packet is never received, which can happen under certain
|
|
|
|
|
circumstances.
|
2011-04-07 10:18:06 +02:00
|
|
|
|
- Refactor and review read_packet().
|
2011-07-29 22:26:38 +02:00
|
|
|
|
- Handle better the configuration file reading
|
|
|
|
|
Get rid of the "Cannot open configuration file" error, in quiet
|
|
|
|
|
mode and when the default configuration file has to be used (no
|
|
|
|
|
file specified by the user with -f).
|
2011-08-26 16:08:39 +02:00
|
|
|
|
- Filter the number of implicit packets per mobile?
|
2011-12-30 14:42:37 +01:00
|
|
|
|
Currently, in passive or mixed mode, *all* the received packets are
|
2011-08-26 16:08:39 +02:00
|
|
|
|
transmitted to the aggregator.
|
|
|
|
|
- Option "read-only autocalibration"?
|
|
|
|
|
Listen for autocalibration requests without sending requests.
|
2011-03-10 20:55:31 +01:00
|
|
|
|
- read_packet(): use ieee80211_header_size for all implicit packets
|
|
|
|
|
Currently the size is corrected only for data packets.
|
2011-08-26 16:08:39 +02:00
|
|
|
|
- BSD port
|
|
|
|
|
http://www.unixgarden.com/index.php/programmation/introduction-a-la-programmation-wifi-en-c-sous-netbsd
|
|
|
|
|
- Use the "official" radiotap parser? (Expat license)
|
|
|
|
|
http://git.sipsolutions.net/?p=radiotap.git
|
2011-03-10 20:55:31 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* Client
|
|
|
|
|
|
2011-07-29 22:26:38 +02:00
|
|
|
|
- Add verbose & quiet options.
|
|
|
|
|
- Log sent requests?
|
2011-04-07 10:18:06 +02:00
|
|
|
|
- Allow to use a string for the direction?
|
2011-03-10 20:55:31 +01:00
|
|
|
|
Could be nice, but probably useless.
|
|
|
|
|
|
|
|
|
|
|
2011-08-26 16:08:39 +02:00
|
|
|
|
* UDP to HTTP
|
|
|
|
|
|
|
|
|
|
- Command-line options (port numbers, -v/-q, -h, -V).
|
|
|
|
|
- Delete inactive clients after a given amount of time.
|
|
|
|
|
- Refactor prepare_answer().
|
|
|
|
|
|
|
|
|
|
|
2012-02-06 17:17:25 +01:00
|
|
|
|
* Positioner
|
2011-03-10 20:55:31 +01:00
|
|
|
|
|
2011-08-01 10:00:19 +02:00
|
|
|
|
- Known bugs
|
2012-02-07 12:41:29 +01:00
|
|
|
|
° Cannot compute the error (Real) for autocalibration requests.
|
2011-12-30 14:42:37 +01:00
|
|
|
|
° Unit tests are currently unmaintained. Do not try to run them.
|
2011-08-01 10:00:19 +02:00
|
|
|
|
|
|
|
|
|
- Algorithms
|
2011-08-26 16:08:39 +02:00
|
|
|
|
° Add to the result the information "area error" (whether on not the
|
|
|
|
|
computed result is in the same room as the real position).
|
|
|
|
|
° Handle the power and antenna gain difference between the
|
|
|
|
|
calibration mobile (or pseudo-mobile, for autocalibration) and the
|
|
|
|
|
mobile to position.
|
2012-02-07 12:41:29 +01:00
|
|
|
|
° MinMax: add option to set the step (and use a different step for X,
|
|
|
|
|
Y and Z?).
|
2012-05-02 17:29:56 +02:00
|
|
|
|
° MinMax: reduce the research space as proposed by F. Lassabe (PhD
|
|
|
|
|
report, Fig. 2.6 p. 38 and explanations pp. 38-39).
|
2011-08-01 10:00:19 +02:00
|
|
|
|
|
|
|
|
|
- Autocalibration
|
|
|
|
|
° Generate reference points in 3D.
|
2012-02-07 12:41:29 +01:00
|
|
|
|
° To select the reference APs, we should use the distance along with
|
|
|
|
|
the angle and coverage.
|
2011-08-01 10:00:19 +02:00
|
|
|
|
° Handle 2 APs, not only >2 APs.
|
|
|
|
|
° Find why some CalibrationRequest were not deleted when
|
|
|
|
|
calling Stock::delete_calibration_request() (via
|
|
|
|
|
ReferencePoint::delete_requests()).
|
2012-01-09 10:31:12 +01:00
|
|
|
|
° Option z-level-number: the Z coordinate represents the number of
|
|
|
|
|
the building's level. If unactivated, the topology is used to
|
|
|
|
|
determine a change of level.
|
2011-08-01 10:00:19 +02:00
|
|
|
|
|
|
|
|
|
- Refactoring
|
|
|
|
|
° Split Stock::generate_reference_point() into several functions.
|
|
|
|
|
° Write a class for Request::type?
|
|
|
|
|
CalibrationRequest::direction uses a dedicated class Direction, why
|
|
|
|
|
not Request::type? That would simplify writing of the type to
|
|
|
|
|
streams (no need to cast each time anymore).
|
|
|
|
|
° Wi-Fi devices' list
|
|
|
|
|
. Merge Stock::mobiles & Stock::aps?
|
|
|
|
|
. Factorise AccessPointsReaderCSV & MobilesReaderCSV?
|
|
|
|
|
° Members renaming
|
|
|
|
|
. InputMedium:
|
|
|
|
|
. - current_line_nb & get_current_line_nb()
|
|
|
|
|
. - get_next_request() −> read_next_request()
|
|
|
|
|
. Input: get_next_request() −> read_next_request()
|
|
|
|
|
. Area: p_min et p_max −> coord_min et coord_max
|
|
|
|
|
|
|
|
|
|
- User interface
|
|
|
|
|
° When reading the APs, add them to the mobiles' list (or another
|
|
|
|
|
way to be able to have a single entry for an AP).
|
2011-12-30 14:42:37 +01:00
|
|
|
|
° Add option positioning.self-calibrate (or autocalibrate), short
|
|
|
|
|
option -A, to activate automatically the options needed by the
|
|
|
|
|
autocalibration.
|
2011-08-01 10:00:19 +02:00
|
|
|
|
° Improve --verbose (and/or debug level): print the options, etc.
|
|
|
|
|
° Case-insensitive string comparison (for algorithm names, etc.).
|
|
|
|
|
° Use a prefix for configuration files (search for config files set
|
2012-02-06 17:17:25 +01:00
|
|
|
|
with relative path in owlps-positioner.cfg in the same directory).
|
2011-08-01 10:00:19 +02:00
|
|
|
|
|
|
|
|
|
- Optimisation & code improvement
|
2011-08-26 16:08:39 +02:00
|
|
|
|
° Multithreading:
|
2011-12-30 14:42:37 +01:00
|
|
|
|
. algorithms (parallelize computation of the different algorithms
|
2012-02-07 12:41:29 +01:00
|
|
|
|
for the same request);
|
2011-08-26 16:08:39 +02:00
|
|
|
|
. and/or requests (parallelize computation of several requests).
|
|
|
|
|
It would be possible (overkill?) to have a group of worker threads
|
|
|
|
|
and a job queue.
|
2011-08-01 10:00:19 +02:00
|
|
|
|
° ReferencePoint: the request list should be an unordered_set
|
|
|
|
|
instead of a vector, to guarantee the unicity of the elements.
|
|
|
|
|
° Pre-allocate vectors' memory with reserve().
|
|
|
|
|
"C++ en action", p. 217.
|
|
|
|
|
° Copy of containers to streams (in some operator<<() for
|
|
|
|
|
instance).
|
|
|
|
|
"C++ en action", p. 275.
|
|
|
|
|
° Review all the classes to respect principles exposed in "Coder
|
2012-02-07 12:41:29 +01:00
|
|
|
|
proprement", chapter 6, p. 103: do not implement accessors for each
|
2011-08-01 10:00:19 +02:00
|
|
|
|
class attribute, etc.
|
|
|
|
|
|
|
|
|
|
- Unit tests
|
2011-12-30 14:42:37 +01:00
|
|
|
|
° Update (rewrite?) tests.
|
2011-08-01 10:00:19 +02:00
|
|
|
|
° Unfinished tests:
|
|
|
|
|
. InputDataReader
|
|
|
|
|
. Input
|
|
|
|
|
. Output
|
|
|
|
|
. Positioning
|
|
|
|
|
° Test InterlinkNetworks::compute() ?
|
|
|
|
|
° Timestamp: there is a probability of 10^-6 that the value in
|
|
|
|
|
nanoseconds and the rounded value in milliseconds are identical, in
|
|
|
|
|
which case some tests can fail.
|